SCHEMA: Add file rule for phenotype tables #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
added
schema
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1672 +/- ##
==========================================
+ Coverage 87.92% 88.04% +0.11%
==========================================
Files 16 16
Lines 1375 1380 +5
==========================================
+ Hits 1209 1215 +6
+ Misses 166 165 -1 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
effigies
changed the title
effigies
force-pushed
the
schema/phenotype
branch
3 times, most recently
from
c3c6696 to
1a056e7
Compare
effigies
force-pushed
the
schema/phenotype
branch
from
35ff261 to
dddc5a3
Compare
effigies
force-pushed
the
schema/phenotype
branch
from
dddc5a3 to
0ff1fab
Compare
effigies
force-pushed
the
schema/phenotype
branch
from
0ff1fab to
68b93db
Compare
effigies
added a commit
to effigies/legacy-bids-validator
that referenced
this pull request
Apr 26, 2024
effigies
added a commit
to bids-standard/legacy-validator
that referenced
this pull request
Apr 26, 2024
9 tasks
effigies
force-pushed
the
schema/phenotype
branch
from
68b93db to
e29b1b8
Compare
effigies
added a commit
to bids-standard/legacy-validator
that referenced
this pull request
Apr 26, 2024
effigies
force-pushed
the
schema/phenotype
branch
from
1c6b8e8 to
49723f3
Compare
effigies
added a commit
to bids-standard/legacy-validator
that referenced
this pull request
May 2, 2024
effigies
added a commit
to bids-standard/legacy-validator
that referenced
this pull request
May 2, 2024
effigies
added a commit
to bids-standard/legacy-validator
that referenced
this pull request
May 2, 2024
9 tasks
effigies
added a commit
to effigies/legacy-bids-validator
that referenced
this pull request
May 6, 2024
effigies
added a commit
to effigies/legacy-bids-validator
that referenced
this pull request
May 10, 2024
This was referenced May 20, 2024
rwblair
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly amends how
stemrules work, by making the stem a glob pattern and allowing it to coexist withdatatype. This hacks 'phenotype' into thedatatypestructure; in the absence of entities, it works correctly for now.I don't know that this is a long-term solution, but it seems good enough for now with minimal changes required to the schematools or the JS schema validator.
This is intended to be compatible with, but not actually dependent on #1693.